Re: [Mesa-dev] [PATCH] state_tracker: Fix check for scissor enabled when < 0.

2016-10-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Oct 15, 2016 1:37 AM, "Eric Anholt" wrote: > DEQP's clear tests like to give us x + w < 0 or y + h < 0. Since we > were comparing to an unsigned, it would get promoted to unsigned and come > out as bignum >= width or height and we would clear the whole fb ins

Re: [Mesa-dev] [PATCH] state_tracker: Fix check for scissor enabled when < 0.

2016-10-15 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 10/15/2016 10:37 AM, Eric Anholt wrote: > DEQP's clear tests like to give us x + w < 0 or y + h < 0. Since we > were comparing to an unsigned, it would get promoted to unsigned and come > out as bignum >= width or height and we would clear the whole fb instead > o

Re: [Mesa-dev] [PATCH] state_tracker: Fix check for scissor enabled when < 0.

2016-10-14 Thread Kenneth Graunke
On Friday, October 14, 2016 4:37:38 PM PDT Eric Anholt wrote: > DEQP's clear tests like to give us x + w < 0 or y + h < 0. Since we > were comparing to an unsigned, it would get promoted to unsigned and come > out as bignum >= width or height and we would clear the whole fb instead > of none of th

[Mesa-dev] [PATCH] state_tracker: Fix check for scissor enabled when < 0.

2016-10-14 Thread Eric Anholt
DEQP's clear tests like to give us x + w < 0 or y + h < 0. Since we were comparing to an unsigned, it would get promoted to unsigned and come out as bignum >= width or height and we would clear the whole fb instead of none of the fb. Fixes 10 tests under deqp-gles2/functional/color_clear. --- sr