Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-04 Thread Jose Fonseca
Committed. Thanks for the patch, Oliver, and everybody else for their feedback. Jose - Original Message - > That old bug was hidden but the clipper always interpolating in 3d > space no matter what it should have been doing. Now that the > interpolation has been fixed, the bug shows up.

Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-02 Thread Paul Berry
On 2 July 2012 15:12, Vadim Girlin wrote: > On Mon, 2012-07-02 at 14:19 -0700, Paul Berry wrote: > > On 2 July 2012 13:45, Vadim Girlin wrote: > > > > > On Mon, 2012-07-02 at 10:08 -0700, Paul Berry wrote: > > > > On 2 July 2012 08:04, Vadim Girlin wrote: > > > > On Sun, 2012-06-24 at 1

Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-02 Thread Vadim Girlin
On Mon, 2012-07-02 at 14:19 -0700, Paul Berry wrote: > On 2 July 2012 13:45, Vadim Girlin wrote: > > > On Mon, 2012-07-02 at 10:08 -0700, Paul Berry wrote: > > > On 2 July 2012 08:04, Vadim Girlin wrote: > > > On Sun, 2012-06-24 at 11:18 +0200, Olivier Galibert wrote: > > > > Tha

Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-02 Thread Paul Berry
On 2 July 2012 13:45, Vadim Girlin wrote: > On Mon, 2012-07-02 at 10:08 -0700, Paul Berry wrote: > > On 2 July 2012 08:04, Vadim Girlin wrote: > > On Sun, 2012-06-24 at 11:18 +0200, Olivier Galibert wrote: > > > That old bug was hidden but the clipper always interpolating > >

Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-02 Thread Vadim Girlin
On Mon, 2012-07-02 at 10:08 -0700, Paul Berry wrote: > On 2 July 2012 08:04, Vadim Girlin wrote: > On Sun, 2012-06-24 at 11:18 +0200, Olivier Galibert wrote: > > That old bug was hidden but the clipper always interpolating > in 3d > > space no matter what it should

Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-02 Thread Paul Berry
On 2 July 2012 08:04, Vadim Girlin wrote: > On Sun, 2012-06-24 at 11:18 +0200, Olivier Galibert wrote: > > That old bug was hidden but the clipper always interpolating in 3d > > space no matter what it should have been doing. Now that the > > interpolation has been fixed, the bug shows up. > > >

Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-02 Thread Vadim Girlin
On Sun, 2012-06-24 at 11:18 +0200, Olivier Galibert wrote: > That old bug was hidden but the clipper always interpolating in 3d > space no matter what it should have been doing. Now that the > interpolation has been fixed, the bug shows up. > > Fixes bugzilla 51364. > > Signed-off-by: Ol

Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-02 Thread Marek Olšák
FWIW, r600g passes the test and this commit has no effect on the driver. Marek On Mon, Jul 2, 2012 at 1:24 PM, Jose Fonseca wrote: > This would affect not only llvmpipe but all gallium drivers, even those not > using draw module. > > Can other gallium driver maintainers acknowledge this patch a

Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-02 Thread Jose Fonseca
This would affect not only llvmpipe but all gallium drivers, even those not using draw module. Can other gallium driver maintainers acknowledge this patch also fixes their test with their drivers? Jose - Original Message - > That old bug was hidden but the clipper always interpolating

[Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-06-24 Thread Olivier Galibert
That old bug was hidden but the clipper always interpolating in 3d space no matter what it should have been doing. Now that the interpolation has been fixed, the bug shows up. Fixes bugzilla 51364. Signed-off-by: Olivier Galibert diff --git a/src/mesa/state_tracker/st_program.c b/src/