Re: [Mesa-dev] [PATCH] st: Don't try to finalize the texture in st_render_texture().

2018-03-28 Thread Eric Anholt
Brian Paul writes: > On 03/27/2018 10:14 PM, Eric Anholt wrote: >> We can't necessarily finalize the texture at this point if we're rendering >> to a texture image whose format is different from the baselevel's format. > > This is just a test suite scenario, right? It's not the sort of thing a

Re: [Mesa-dev] [PATCH] st: Don't try to finalize the texture in st_render_texture().

2018-03-28 Thread Brian Paul
On 03/27/2018 10:14 PM, Eric Anholt wrote: We can't necessarily finalize the texture at this point if we're rendering to a texture image whose format is different from the baselevel's format. This is just a test suite scenario, right? It's not the sort of thing a real app would do, I hope.

[Mesa-dev] [PATCH] st: Don't try to finalize the texture in st_render_texture().

2018-03-27 Thread Eric Anholt
We can't necessarily finalize the texture at this point if we're rendering to a texture image whose format is different from the baselevel's format. This was introduced as a fix for fbo-incomplete-texture-03 in de414f491526610bb260c73805c81ba413388e20, but the later fix for vmware on that testcase