Re: [Mesa-dev] [PATCH] st/vdpau: fix compiler warning in vlVdpVideoMixerRender

2016-12-05 Thread Nayan Deshmukh
On Mon, Dec 5, 2016 at 6:28 PM, Emil Velikov wrote: > This seems like the compiler being silly since it fails to match if > (vmixer->bicubic.filter || ...) with the else of if > (!vmixer->noise_reduction.filter && ...) > > As usual, some wild idea(s) come to mind. Please don't read too much into

Re: [Mesa-dev] [PATCH] st/vdpau: fix compiler warning in vlVdpVideoMixerRender

2016-12-05 Thread Emil Velikov
This seems like the compiler being silly since it fails to match if (vmixer->bicubic.filter || ...) with the else of if (!vmixer->noise_reduction.filter && ...) As usual, some wild idea(s) come to mind. Please don't read too much into them. - move current_picture_structure validation further up

Re: [Mesa-dev] [PATCH] st/vdpau: fix compiler warning in vlVdpVideoMixerRender

2016-12-05 Thread Nayan Deshmukh
Christian, Thanks for the review. Can you push the patch for me? Regards, Nayan On Mon, Dec 5, 2016 at 1:17 PM, Christian König wrote: > Am 05.12.2016 um 06:25 schrieb Nayan Deshmukh: >> >> Signed-off-by: Nayan Deshmukh > > > Reviewed-by: Christian König . > > >> --- >> src/gallium/state_trac

Re: [Mesa-dev] [PATCH] st/vdpau: fix compiler warning in vlVdpVideoMixerRender

2016-12-05 Thread Christian König
Am 05.12.2016 um 06:25 schrieb Nayan Deshmukh: Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König . --- src/gallium/state_trackers/vdpau/mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/mixer.c b/src/gallium/state_tracke

[Mesa-dev] [PATCH] st/vdpau: fix compiler warning in vlVdpVideoMixerRender

2016-12-04 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/mixer.c b/src/gallium/state_trackers/vdpau/mixer.c index c205427..aca43c1 100644 --- a/src/gallium/state_trackers/vdpau/