Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-30 Thread Andy Furniss
Michel Dänzer wrote: On 30/01/17 12:08 AM, Andy Furniss wrote: Christian König wrote: That looks correct to me, but I'm not deeply enough into the H264 encoding any more. Adding Leo and Boyuan to comment as well. I just sent v2 to list and tried to cc Boyuan and Leo but it failed. git send-

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-30 Thread Christian König
Am 30.01.2017 um 09:17 schrieb Michel Dänzer: On 30/01/17 12:08 AM, Andy Furniss wrote: Christian König wrote: That looks correct to me, but I'm not deeply enough into the H264 encoding any more. Adding Leo and Boyuan to comment as well. I just sent v2 to list and tried to cc Boyuan and Leo b

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-30 Thread Michel Dänzer
On 30/01/17 12:08 AM, Andy Furniss wrote: > Christian König wrote: >> That looks correct to me, but I'm not deeply enough into the H264 >> encoding any more. >> >> Adding Leo and Boyuan to comment as well. > > I just sent v2 to list and tried to cc Boyuan and Leo but it failed. > > git send-email

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-29 Thread Andy Furniss
Christian König wrote: That looks correct to me, but I'm not deeply enough into the H264 encoding any more. Adding Leo and Boyuan to comment as well. I just sent v2 to list and tried to cc Boyuan and Leo but it failed. git send-email -1 -v2 --to=mesa-dev@lists.freedesktop.org --cc=christian.

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-29 Thread Andy Furniss
Mark Thompson wrote: On 27/01/17 22:06, Andy Furniss wrote: Could use floats I guess like I did here. https://cgit.freedesktop.org/mesa/mesa/commit/?id=a5993022275c20061ac025d9adc26c5f9d02afee I don't know what the preference is between float and int. I think float is fine here? I don't k

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-27 Thread Mark Thompson
On 27/01/17 22:06, Andy Furniss wrote: > Mark Thompson wrote: >> On 26/01/17 18:26, Andy Furniss wrote: >>> Tested with ffmpeg and gst-vaapi. Without this bits per >>> frame is set way too low. >>> >>> Signed-off-by: Andy Furniss >>> --- >>> src/gallium/state_trackers/va/picture.c | 32 >>>

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-27 Thread Andy Furniss
Mark Thompson wrote: On 26/01/17 18:26, Andy Furniss wrote: Tested with ffmpeg and gst-vaapi. Without this bits per frame is set way too low. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/picture.c | 32 1 file changed, 24 insertions(+), 8 de

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-27 Thread Mark Thompson
On 26/01/17 18:26, Andy Furniss wrote: > Tested with ffmpeg and gst-vaapi. Without this bits per > frame is set way too low. > > Signed-off-by: Andy Furniss > --- > src/gallium/state_trackers/va/picture.c | 32 > 1 file changed, 24 insertions(+), 8 deletions(-) >

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-27 Thread Christian König
That looks correct to me, but I'm not deeply enough into the H264 encoding any more. Adding Leo and Boyuan to comment as well. Regards, Christian. Am 26.01.2017 um 19:26 schrieb Andy Furniss: Tested with ffmpeg and gst-vaapi. Without this bits per frame is set way too low. Signed-off-by: And

[Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-26 Thread Andy Furniss
Tested with ffmpeg and gst-vaapi. Without this bits per frame is set way too low. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/picture.c | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/va/picture.c