Re: [Mesa-dev] [PATCH] st/va: add missing break statement

2015-11-29 Thread Emil Velikov
On 29 November 2015 at 11:52, Christian König wrote: > On 29.11.2015 12:48, Emil Velikov wrote: >> >> Earlier commit factored out the mpeg4 IQ matrix handling into separate >> function, although it forgot to add a break in its case statement. >> Thus the data ended up partially overwritten as the

Re: [Mesa-dev] [PATCH] st/va: add missing break statement

2015-11-29 Thread Christian König
On 29.11.2015 12:48, Emil Velikov wrote: Earlier commit factored out the mpeg4 IQ matrix handling into separate function, although it forgot to add a break in its case statement. Thus the data ended up partially overwritten as the mpeg4 and h265 structs are members of the desc union. Spotted by

[Mesa-dev] [PATCH] st/va: add missing break statement

2015-11-29 Thread Emil Velikov
Earlier commit factored out the mpeg4 IQ matrix handling into separate function, although it forgot to add a break in its case statement. Thus the data ended up partially overwritten as the mpeg4 and h265 structs are members of the desc union. Spotted by Coverity (CID 1341052) Fixes: 64761a841db