Re: [Mesa-dev] [PATCH] st/query: init result data with 0

2017-08-26 Thread Ilia Mirkin
On Sat, Aug 26, 2017 at 3:49 AM, Karol Herbst wrote: > On Sat, Aug 26, 2017 at 3:36 AM, Ilia Mirkin wrote: >> On Fri, Aug 25, 2017 at 8:23 PM, Karol Herbst wrote: >>> On Sat, Aug 26, 2017 at 1:38 AM, Ilia Mirkin wrote: On Fri, Aug 25, 2017 at 7:37 PM, Karol Herbst wrote: > On Sa

Re: [Mesa-dev] [PATCH] st/query: init result data with 0

2017-08-26 Thread Karol Herbst
On Sat, Aug 26, 2017 at 3:36 AM, Ilia Mirkin wrote: > On Fri, Aug 25, 2017 at 8:23 PM, Karol Herbst wrote: >> On Sat, Aug 26, 2017 at 1:38 AM, Ilia Mirkin wrote: >>> On Fri, Aug 25, 2017 at 7:37 PM, Karol Herbst wrote: On Sat, Aug 26, 2017 at 1:30 AM, Ilia Mirkin wrote: > Why is this

Re: [Mesa-dev] [PATCH] st/query: init result data with 0

2017-08-25 Thread Ilia Mirkin
On Fri, Aug 25, 2017 at 8:23 PM, Karol Herbst wrote: > On Sat, Aug 26, 2017 at 1:38 AM, Ilia Mirkin wrote: >> On Fri, Aug 25, 2017 at 7:37 PM, Karol Herbst wrote: >>> On Sat, Aug 26, 2017 at 1:30 AM, Ilia Mirkin wrote: Why is this necessary? If data is not initialized, then presumably

Re: [Mesa-dev] [PATCH] st/query: init result data with 0

2017-08-25 Thread Karol Herbst
On Sat, Aug 26, 2017 at 1:38 AM, Ilia Mirkin wrote: > On Fri, Aug 25, 2017 at 7:37 PM, Karol Herbst wrote: >> On Sat, Aug 26, 2017 at 1:30 AM, Ilia Mirkin wrote: >>> Why is this necessary? If data is not initialized, then presumably >>> pipe->get_query_result will have returned false. >>> >> >>

Re: [Mesa-dev] [PATCH] st/query: init result data with 0

2017-08-25 Thread Ilia Mirkin
On Fri, Aug 25, 2017 at 7:37 PM, Karol Herbst wrote: > On Sat, Aug 26, 2017 at 1:30 AM, Ilia Mirkin wrote: >> Why is this necessary? If data is not initialized, then presumably >> pipe->get_query_result will have returned false. >> > > but it didn't. It might be the drivers fault (in my case nouv

Re: [Mesa-dev] [PATCH] st/query: init result data with 0

2017-08-25 Thread Ilia Mirkin
Why is this necessary? If data is not initialized, then presumably pipe->get_query_result will have returned false. On Fri, Aug 25, 2017 at 7:15 PM, Karol Herbst wrote: > otherwise the result might contain random data. > > fixes on nvc0: > * KHR-GL45.pipeline_statistics_query_tests_ARB.functiona

[Mesa-dev] [PATCH] st/query: init result data with 0

2017-08-25 Thread Karol Herbst
otherwise the result might contain random data. fixes on nvc0: * KHR-GL45.pipeline_statistics_query_tests_ARB.functional_default_qo_values * KHR-GL45.pipeline_statistics_query_tests_ARB.functional_non_rendering_commands_do_not_affect_queries Signed-off-by: Karol Herbst Cc: mesa-sta...@lists.f