Re: [Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-11-10 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 11/11/17 00:46, Rob Clark wrote: In case the IR is NIR, the driver takes reference to the nir_shader. Also, because there are no variants, we need to clone the shader, instead of sharing the reference with gl_program, which would result in a double free in _mesa_d

[Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-11-10 Thread Rob Clark
In case the IR is NIR, the driver takes reference to the nir_shader. Also, because there are no variants, we need to clone the shader, instead of sharing the reference with gl_program, which would result in a double free in _mesa_delete_program(). Signed-off-by: Rob Clark Reviewed-by: Marek Olšák

Re: [Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-10-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Oct 30, 2017 at 3:36 PM, Rob Clark wrote: > In case the IR is NIR, the driver takes reference to the nir_shader. > Also, because there are no variants, we need to clone the shader, > instead of sharing the reference with gl_program, which would result > in

[Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-10-30 Thread Rob Clark
In case the IR is NIR, the driver takes reference to the nir_shader. Also, because there are no variants, we need to clone the shader, instead of sharing the reference with gl_program, which would result in a double free in _mesa_delete_program(). Signed-off-by: Rob Clark --- src/mesa/state_trac