Re: [Mesa-dev] [PATCH] st/mesa: fix view template initialization in try_pbo_readpixels

2017-09-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Sep 1, 2017 at 1:53 AM, wrote: > From: Roland Scheidegger > > I think this is what the code was meant to do, albeit as far as I can tell > the redundant initialization some analyzers complain about should work as > well just fine (only the first layer wi

Re: [Mesa-dev] [PATCH] st/mesa: fix view template initialization in try_pbo_readpixels

2017-08-31 Thread Roland Scheidegger
Am 01.09.2017 um 02:32 schrieb Brian Paul: > On 08/31/2017 05:53 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> I think this is what the code was meant to do, albeit as far as I can >> tell >> the redundant initialization some analyzers complain about should work as >> well just f

Re: [Mesa-dev] [PATCH] st/mesa: fix view template initialization in try_pbo_readpixels

2017-08-31 Thread Brian Paul
On 08/31/2017 05:53 PM, srol...@vmware.com wrote: From: Roland Scheidegger I think this is what the code was meant to do, albeit as far as I can tell the redundant initialization some analyzers complain about should work as well just fine (only the first layer will be used, if the view contains

[Mesa-dev] [PATCH] st/mesa: fix view template initialization in try_pbo_readpixels

2017-08-31 Thread sroland
From: Roland Scheidegger I think this is what the code was meant to do, albeit as far as I can tell the redundant initialization some analyzers complain about should work as well just fine (only the first layer will be used, if the view contains one or more layers doesn't really matter). Bugzill