Re: [Mesa-dev] [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps()

2016-04-14 Thread Roland Scheidegger
Am 14.04.2016 um 23:12 schrieb Brian Paul: > I neglected to free the sampler view which was created earlier in the > function. So for each glCallLists() command that used the bitmap atlas > to draw text, we'd leak a smpler view object. > > Also, check for st_create_texture_sampler_view() failure

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps()

2016-04-14 Thread Charmaine Lee
Looks good to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, April 14, 2016 2:12 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; 11.1 11.2 Subject: [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps() I neglected to

[Mesa-dev] [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps()

2016-04-14 Thread Brian Paul
I neglected to free the sampler view which was created earlier in the function. So for each glCallLists() command that used the bitmap atlas to draw text, we'd leak a smpler view object. Also, check for st_create_texture_sampler_view() failure and record GL_OUT_OF_MEMORY. Cc: "11.1 11.2" --- s