Re: [Mesa-dev] [PATCH] st/mesa: fix glReadBuffer() assertion failure

2016-04-08 Thread Jose Fonseca
On 08/04/16 00:45, Brian Paul wrote: If the first call in a GL app is glReadPixels(GL_FRONT) we'd fail the assert(st->ctx->FragmentProgram._Current) at st_atom_shader.c:114 in update_fp(). This is because we were calling st_validate_state() without first updating Mesa state with _mesa_update_sta

Re: [Mesa-dev] [PATCH] st/mesa: fix glReadBuffer() assertion failure

2016-04-07 Thread Brian Paul
On 04/07/2016 06:17 PM, Roland Scheidegger wrote: Am 08.04.2016 um 01:45 schrieb Brian Paul: If the first call in a GL app is glReadPixels(GL_FRONT) we'd fail the assert(st->ctx->FragmentProgram._Current) at st_atom_shader.c:114 in update_fp(). This is because we were calling st_validate_state(

Re: [Mesa-dev] [PATCH] st/mesa: fix glReadBuffer() assertion failure

2016-04-07 Thread Roland Scheidegger
Am 08.04.2016 um 01:45 schrieb Brian Paul: > If the first call in a GL app is glReadPixels(GL_FRONT) we'd fail the > assert(st->ctx->FragmentProgram._Current) at st_atom_shader.c:114 in > update_fp(). > > This is because we were calling st_validate_state() without first > updating Mesa state with

[Mesa-dev] [PATCH] st/mesa: fix glReadBuffer() assertion failure

2016-04-07 Thread Brian Paul
If the first call in a GL app is glReadPixels(GL_FRONT) we'd fail the assert(st->ctx->FragmentProgram._Current) at st_atom_shader.c:114 in update_fp(). This is because we were calling st_validate_state() without first updating Mesa state with _mesa_update_state(). The regression came from commit