Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

On Wed, Jan 9, 2019 at 11:58 AM Roland Scheidegger wrote: > Am 08.01.19 um 21:03 schrieb Marek Olšák: > > On Tue, Jan 8, 2019 at 12:54 PM Roland Scheidegger > > wrote: > > > > Am 08.01.19 um 17:17 schrieb Marek Olšák: > > > From: Marek Olšák mailto:marek.ol...@

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

Am 08.01.19 um 21:03 schrieb Marek Olšák: > On Tue, Jan 8, 2019 at 12:54 PM Roland Scheidegger > wrote: > > Am 08.01.19 um 17:17 schrieb Marek Olšák: > > From: Marek Olšák mailto:marek.ol...@amd.com>> > > > > We have found some pipe_surface leaks interna

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

On Tue, Jan 8, 2019 at 5:17 PM Marek Olšák wrote: > > From: Marek Olšák > > We have found some pipe_surface leaks internally. > > This is the same code as surface_destroy in radeonsi. > Ideally, surface_destroy would be in pipe_screen. > No, pipe_surfaces are not context objects. > > Cc: 18.3 19.

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

On Tue, Jan 8, 2019 at 12:54 PM Roland Scheidegger wrote: > Am 08.01.19 um 17:17 schrieb Marek Olšák: > > From: Marek Olšák > > > > We have found some pipe_surface leaks internally. > > > > This is the same code as surface_destroy in radeonsi. > > Ideally, surface_destroy would be in pipe_screen

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

Am 08.01.19 um 17:17 schrieb Marek Olšák: > From: Marek Olšák > > We have found some pipe_surface leaks internally. > > This is the same code as surface_destroy in radeonsi. > Ideally, surface_destroy would be in pipe_screen. > No, pipe_surfaces are not context objects. Well they are supposed to

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

LGTM. Reviewed-by: Brian Paul On 01/08/2019 09:17 AM, Marek Olšák wrote: > From: Marek Olšák > > We have found some pipe_surface leaks internally. > > This is the same code as surface_destroy in radeonsi. > Ideally, surface_destroy would be in pipe_screen. > No, pipe_surfaces are not context

[Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

From: Marek Olšák We have found some pipe_surface leaks internally. This is the same code as surface_destroy in radeonsi. Ideally, surface_destroy would be in pipe_screen. No, pipe_surfaces are not context objects. Cc: 18.3 19.0 --- src/gallium/auxiliary/util/u_inlines.h | 19