Re: [Mesa-dev] [PATCH] st/mesa: align cube map arrays layers

2015-04-09 Thread Marek Olšák
This will prevent similar bugs in the future. It should be a candidate for stable. Whether the alignment is done unconditionally (like Ilia suggested) or not: Reviewed-by: Marek Olšák Marek On Wed, Apr 8, 2015 at 2:02 AM, Dave Airlie wrote: > From: Dave Airlie > > We create textures internal

Re: [Mesa-dev] [PATCH] st/mesa: align cube map arrays layers

2015-04-09 Thread Marek Olšák
On Wed, Apr 8, 2015 at 2:43 AM, Ilia Mirkin wrote: > On Tue, Apr 7, 2015 at 8:02 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> We create textures internally for texsubimage, and we use >> the values from sub image to create a new texture, however >> we don't align these to valid sizes, and c

Re: [Mesa-dev] [PATCH] st/mesa: align cube map arrays layers

2015-04-07 Thread Dave Airlie
On 8 April 2015 at 10:43, Ilia Mirkin wrote: > On Tue, Apr 7, 2015 at 8:02 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> We create textures internally for texsubimage, and we use >> the values from sub image to create a new texture, however >> we don't align these to valid sizes, and cube ma

Re: [Mesa-dev] [PATCH] st/mesa: align cube map arrays layers

2015-04-07 Thread Ilia Mirkin
On Tue, Apr 7, 2015 at 8:02 PM, Dave Airlie wrote: > From: Dave Airlie > > We create textures internally for texsubimage, and we use > the values from sub image to create a new texture, however > we don't align these to valid sizes, and cube map arrays > must have an array size aligned to 6. > >

[Mesa-dev] [PATCH] st/mesa: align cube map arrays layers

2015-04-07 Thread Dave Airlie
From: Dave Airlie We create textures internally for texsubimage, and we use the values from sub image to create a new texture, however we don't align these to valid sizes, and cube map arrays must have an array size aligned to 6. This fixes texsubimage cube_map_array on CAYMAN at least, (it was