Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-24 Thread Marek Olšák
On Tue, Jul 25, 2017 at 12:20 AM, Charmaine Lee wrote: > > Hi Marek, > > I have pushed the fix for Steam. Commit > bbc29393d3beaf6344c7188547b4ff61b63946ae > should fix the problem. Can you please try? Thanks. Steam is working fine now. Marek ___ mes

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-24 Thread Charmaine Lee
@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface Hi Charmaine, Which commits do I need to revert in 17.2 to unbreak Steam on Mesa? I guess it's more than one. Thanks, Marek On Sat, Jul 22, 2017 at 3:05 AM, Charmaine Lee wrote: > > Hi Christo

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-24 Thread Marek Olšák
t; Thanks. > -Charmaine > > > From: mesa-dev on behalf of > Christoph Haag > Sent: Friday, July 21, 2017 4:52:41 PM > To: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface > > This

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-21 Thread Christoph Haag
mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface > > This patch breaks steam for me. Segfault backtrace: > > #0 0x0023 in ?? () > No symbol table info available. > #1 0xf6b1a417 in _mesa_hash_ta

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-21 Thread Charmaine Lee
Hi Christoph, Can you provide an apitrace of the test that crashes? Thanks. -Charmaine From: mesa-dev on behalf of Christoph Haag Sent: Friday, July 21, 2017 4:52:41 PM To: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] st/mesa: add

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-21 Thread Christoph Haag
This patch breaks steam for me. Segfault backtrace: #0 0x0023 in ?? () No symbol table info available. #1 0xf6b1a417 in _mesa_hash_table_search (ht=0x585bb7e8, key=0x5820ee88) at hash_table.c:246 __PRETTY_FUNCTION__ = "_mesa_hash_table_search" #2 0xf6a4488e in st_framebuffer_iface_

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-21 Thread Emil Velikov
On 20 July 2017 at 19:26, Charmaine Lee wrote: > With this patch, the st manager will maintain a hash table for > the active framebuffer interface objects. A destroy_drawable interface > is added to allow the state tracker to notify the st manager to remove > the associated framebuffer interface o

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-20 Thread Brian Paul
Looks good to me, but you might want to wait a day to see if there's any additional review feedback. Reviewed-by: Brian Paul On 07/20/2017 12:26 PM, Charmaine Lee wrote: With this patch, the st manager will maintain a hash table for the active framebuffer interface objects. A destroy_drawabl

[Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-20 Thread Charmaine Lee
With this patch, the st manager will maintain a hash table for the active framebuffer interface objects. A destroy_drawable interface is added to allow the state tracker to notify the st manager to remove the associated framebuffer interface object from the hash table, so the associated framebuffer