Re: [Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

2016-06-20 Thread Marek Olšák
On Fri, Jun 17, 2016 at 7:15 PM, Francesco Ansanelli wrote: > Hi Erik, > Thanks for your feedback. > Can you suggest a better subject? st/mesa: handle negative _ColorDrawBufferIndexes values correctly > After some thinking, should I cast gl_buffer_index before calling the > function? No if ther

Re: [Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

2016-06-17 Thread Francesco Ansanelli
Hi Erik, Thanks for your feedback. Can you suggest a better subject? After some thinking, should I cast gl_buffer_index before calling the function? Thanks Francesco Il 17 giu 2016 12:39, "Erik Faye-Lund" ha scritto: > Now the subject no longer makes any sense. > > On Thu, Jun 16, 2016 at 7:02 AM

Re: [Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

2016-06-17 Thread Erik Faye-Lund
Now the subject no longer makes any sense. On Thu, Jun 16, 2016 at 7:02 AM, wrote: > From: Francesco Ansanelli > > --- > src/mesa/state_tracker/st_cb_fbo.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_cb_fbo.c > b/src/mesa/state_tracker

[Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

2016-06-16 Thread francians
From: Francesco Ansanelli --- src/mesa/state_tracker/st_cb_fbo.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index a53b95a..950ec3e 100644 --- a/src/mesa/state_tracker/st_cb_fbo.c +++ b/src/mesa/s

Re: [Mesa-dev] [PATCH] st/mesa: Remove tautological check

2016-06-15 Thread Ilia Mirkin
I'd say the proper action is to fix the idx type... we have code like: src/mesa/main/buffers.c: fb->_ColorDrawBufferIndexes[buf] = -1; src/mesa/main/mtypes.h: GLint _ColorDrawBufferIndexes[MAX_DRAW_BUFFERS]; /**< BUFFER_x or -1 */ -ilia On Wed, Jun 15, 2016 at 3:25 PM, wrote: > Fro

[Mesa-dev] [PATCH] st/mesa: Remove tautological check

2016-06-15 Thread francians
Hi list, this is my very first patch and it's inspired by this one: https://lists.freedesktop.org/archives/mesa-dev/2016-May/118822.html to address the -Wtautological compiler warning Cheers, Francesco ___ mesa-dev mailing list mesa-dev@lists.freedes

[Mesa-dev] [PATCH] st/mesa: Remove tautological check

2016-06-15 Thread francians
From: Francesco Ansanelli --- src/mesa/state_tracker/st_cb_fbo.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index a53b95a..ba9955c 100644 --- a/src/mesa/state_tracker/st_cb_fbo.c +++ b/src/me