Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: don't increase immediate index by 1.

2016-06-21 Thread Dave Airlie
On 22 June 2016 at 11:06, Ilia Mirkin wrote: > Is that correct in the case where I have something like > > dvec4 foo = ... > bool x = (foo == dvec4(0, 1, 2, 3)); > > ? Yes, since immediates are repacked, and relooked up. So if you do dvec4(1, 2, 2, 1) you only end up using two immediate location

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: don't increase immediate index by 1.

2016-06-21 Thread Ilia Mirkin
Is that correct in the case where I have something like dvec4 foo = ... bool x = (foo == dvec4(0, 1, 2, 3)); ? Can you elaborate a little bit more as to why this is right? Shouldn't this be based on the swizzle of the src[j] argument? [Note, I haven't carefully read all the surrounding code.] O

[Mesa-dev] [PATCH] st/glsl_to_tgsi: don't increase immediate index by 1.

2016-06-21 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 9de603c..3d8ddc3 100644 --- a/src/mesa/s