Re: [Mesa-dev] [PATCH] st/dri: Initialise modifier to INVALID for DRI2

2018-04-02 Thread Daniel Stone
On 2 April 2018 at 18:52, Eric Anholt wrote: > Daniel Stone writes: >> When allocating a buffer for DRI2, set the modifier to INVALID to inform >> the backend that we have no supplied modifiers and it should do its own >> thing. The missed initialisation forced linear, even if the >> implementati

Re: [Mesa-dev] [PATCH] st/dri: Initialise modifier to INVALID for DRI2

2018-04-02 Thread Eric Anholt
Daniel Stone writes: > When allocating a buffer for DRI2, set the modifier to INVALID to inform > the backend that we have no supplied modifiers and it should do its own > thing. The missed initialisation forced linear, even if the > implementation had made other decisions. This makes sense. Re

[Mesa-dev] [PATCH] st/dri: Initialise modifier to INVALID for DRI2

2018-04-02 Thread Daniel Stone
When allocating a buffer for DRI2, set the modifier to INVALID to inform the backend that we have no supplied modifiers and it should do its own thing. The missed initialisation forced linear, even if the implementation had made other decisions. This resulted in VC4 DRI2 clients failing with: Mo