Re: [Mesa-dev] [PATCH] st/dri: Fix driver loading if swrast isn't built

2014-08-03 Thread Aaron Watry
On Sun, Aug 3, 2014 at 12:30 PM, Emil Velikov wrote: > On 03/08/14 18:13, Aaron Watry wrote: >> On Sun, Aug 3, 2014 at 12:00 PM, Emil Velikov >> wrote: >> >> Yup, when I finally managed to bisect this down to the commit that >> added the kms_swrast_create_screen function, I went back to the com

Re: [Mesa-dev] [PATCH] st/dri: Fix driver loading if swrast isn't built

2014-08-03 Thread Emil Velikov
On 03/08/14 18:13, Aaron Watry wrote: > On Sun, Aug 3, 2014 at 12:00 PM, Emil Velikov > wrote: >> On 02/08/14 22:21, Aaron Watry wrote: >>> If building hardware drivers only, then kms_swrast_create_screen >>> won't be defined in inline_drm_helper.h and hardware drivers will >>> fail to dlopen as

Re: [Mesa-dev] [PATCH] st/dri: Fix driver loading if swrast isn't built

2014-08-03 Thread Aaron Watry
On Sun, Aug 3, 2014 at 12:00 PM, Emil Velikov wrote: > On 02/08/14 22:21, Aaron Watry wrote: >> If building hardware drivers only, then kms_swrast_create_screen >> won't be defined in inline_drm_helper.h and hardware drivers will >> fail to dlopen as a result. >> > Hmm it seems that it will fail t

Re: [Mesa-dev] [PATCH] st/dri: Fix driver loading if swrast isn't built

2014-08-03 Thread Emil Velikov
On 02/08/14 22:21, Aaron Watry wrote: > If building hardware drivers only, then kms_swrast_create_screen > won't be defined in inline_drm_helper.h and hardware drivers will > fail to dlopen as a result. > Hmm it seems that it will fail to dlopen due to the unresolved symbol 'kms_swrast_create_scre

[Mesa-dev] [PATCH] st/dri: Fix driver loading if swrast isn't built

2014-08-02 Thread Aaron Watry
If building hardware drivers only, then kms_swrast_create_screen won't be defined in inline_drm_helper.h and hardware drivers will fail to dlopen as a result. Copy the #if guards from inline_drm_helper.h to dri_kms_init_screen to make the definition/use of the function match. Fixes radeonsi_dri.s