Re: [Mesa-dev] [PATCH] squash: Fix up VPM read optimization.

2016-03-13 Thread Rhys Kidd
On 13 March 2016 at 17:09, Varad Gautam wrote: > - Do not reorder instructions reading packed sources (fixes piglit > regressions with draw-vertices and draw-vertices-user). > --- > Eric, Rhys, with this bit we should be good to go. > > src/gallium/drivers/vc4/vc4_opt_vpm.c | 3 ++- > 1 file cha

[Mesa-dev] [PATCH] squash: Fix up VPM read optimization.

2016-03-13 Thread Varad Gautam
- Do not reorder instructions reading packed sources (fixes piglit regressions with draw-vertices and draw-vertices-user). --- Eric, Rhys, with this bit we should be good to go. src/gallium/drivers/vc4/vc4_opt_vpm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH] squash: Fix up VPM read optimization.

2016-03-10 Thread Rhys Kidd
On 10 March 2016 at 15:21, Eric Anholt wrote: > - There's no reason there would be only 64 operations that read from the > output of a mov from VPM, so we might smash the stack (fixes etqw trace) > > - Fixes segfault where we assumed that a single-use temp had a def (fixes > 2 piglit tests) >

[Mesa-dev] [PATCH] squash: Fix up VPM read optimization.

2016-03-10 Thread Eric Anholt
- There's no reason there would be only 64 operations that read from the output of a mov from VPM, so we might smash the stack (fixes etqw trace) - Fixes segfault where we assumed that a single-use temp had a def (fixes 2 piglit tests) - We need to only mark progress when we actually did the