Re: [Mesa-dev] [PATCH] spirv: fix visiting inner loops with same break/continue block

2018-05-14 Thread Jason Ekstrand
On Mon, May 14, 2018 at 1:22 PM, Jason Ekstrand wrote: > On Mon, May 14, 2018 at 1:05 PM, Samuel Pitoiset < > samuel.pitoi...@gmail.com> wrote: > >> We should stop walking through the CFG when the inner loop's >> break block ends up as the same block as the outer loop's >> continue block because

Re: [Mesa-dev] [PATCH] spirv: fix visiting inner loops with same break/continue block

2018-05-14 Thread Jason Ekstrand
On Mon, May 14, 2018 at 1:05 PM, Samuel Pitoiset wrote: > We should stop walking through the CFG when the inner loop's > break block ends up as the same block as the outer loop's > continue block because we are already going to visit it. > > This fixes the following assertion which ends up by cra

[Mesa-dev] [PATCH] spirv: fix visiting inner loops with same break/continue block

2018-05-14 Thread Samuel Pitoiset
We should stop walking through the CFG when the inner loop's break block ends up as the same block as the outer loop's continue block because we are already going to visit it. This fixes the following assertion which ends up by crashing in RADV or ANV: SPIR-V parsing FAILED: In file ../src/compil