Re: [Mesa-dev] [PATCH] softpipe: implement seamless cubemap support.

2012-12-11 Thread Brian Paul
Just a few minor things below. On 12/11/2012 02:52 AM, Dave Airlie wrote: This adds seamless sampling for cubemap boundaries if requested. The corner case averaging is messy but seems like it should be spec compliant. The face direction stuff is also a bit messy, I've no idea if that could or

Re: [Mesa-dev] [PATCH] softpipe: implement seamless cubemap support.

2012-12-11 Thread Roland Scheidegger
Am 11.12.2012 10:52, schrieb Dave Airlie: > This adds seamless sampling for cubemap boundaries if requested. > > The corner case averaging is messy but seems like it should be spec > compliant. > > The face direction stuff is also a bit messy, I've no idea if that could > or should be simpler, or

[Mesa-dev] [PATCH] softpipe: implement seamless cubemap support.

2012-12-11 Thread Dave Airlie
This adds seamless sampling for cubemap boundaries if requested. The corner case averaging is messy but seems like it should be spec compliant. The face direction stuff is also a bit messy, I've no idea if that could or should be simpler, or even if all my directions are fully correct! Signed-of