Re: [Mesa-dev] [PATCH] scons: Fix build when rtti is disabled

2013-10-16 Thread Alexander von Gluck
On Wed, 2013-10-16 at 15:20 -0700, Jose Fonseca wrote: > +# Match llvm --fno-rtti flag > +cxxflags = env.backtick('llvm-config --cxxflags').split() > +if '-fno-rtti' in cxxflags: > +env.Append(CXXFLAGS = ['-fno-rtti']) Ah, thats a good idea. I d

Re: [Mesa-dev] [PATCH] scons: Fix build when rtti is disabled

2013-10-16 Thread Jose Fonseca
I think this patch does what you need, but with much less unintended side-effects: $ git diff diff --git a/scons/llvm.py b/scons/llvm.py index c1c3736..8388d8e 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -190,6 +190,11 @@ def generate(env): pass env.MergeFlags(

Re: [Mesa-dev] [PATCH] scons: Fix build when rtti is disabled

2013-10-16 Thread Jose Fonseca
I'm going to have to revert this as this patches has a few problems: - it breaks windows builds becuase env[LLVM_CXXFLAGS] is never set there - it is merging not only rtti, but the whole cxxflags (defines etc) which has proven to be a source of troubles (breaks debugging etc.) Jose - Origin

[Mesa-dev] [PATCH] scons: Fix build when rtti is disabled

2013-10-15 Thread Alexander von Gluck IV
* The rtti fix actually dug up a bug in the scons build scripts. * Autotools took the LLVM cpp and cxx flags, while scons only took the cpp flags. * This grabs the cxx flags and applies them where needed. * I'm going to run over this and clean things up further, however this fixes the build whe