Re: [Mesa-dev] [PATCH] renderonly: fix dumb BO allocation for non 32bpp formats

2018-02-01 Thread Lucas Stach
Am Mittwoch, den 31.01.2018, 11:37 + schrieb Daniel Stone: > On 30 January 2018 at 14:22, Lucas Stach > wrote: > > Take into account the resource format, instead of applying a > > hardcoded > > 32bpp. This not only over-allocates 16bpp formats, but also results > > in > > a wrong stride being

Re: [Mesa-dev] [PATCH] renderonly: fix dumb BO allocation for non 32bpp formats

2018-01-31 Thread Daniel Stone
On 30 January 2018 at 14:22, Lucas Stach wrote: > Take into account the resource format, instead of applying a hardcoded > 32bpp. This not only over-allocates 16bpp formats, but also results in > a wrong stride being filled into the handle. Bikeshed: just use util_format_getblocksizebits()? getbl

Re: [Mesa-dev] [PATCH] renderonly: fix dumb BO allocation for non 32bpp formats

2018-01-30 Thread Philipp Zabel
On Tue, 2018-01-30 at 15:22 +0100, Lucas Stach wrote: > Take into account the resource format, instead of applying a hardcoded > 32bpp. This not only over-allocates 16bpp formats, but also results in > a wrong stride being filled into the handle. > > Signed-off-by: Lucas Stach Reviewed-by: Phili

[Mesa-dev] [PATCH] renderonly: fix dumb BO allocation for non 32bpp formats

2018-01-30 Thread Lucas Stach
Take into account the resource format, instead of applying a hardcoded 32bpp. This not only over-allocates 16bpp formats, but also results in a wrong stride being filled into the handle. Signed-off-by: Lucas Stach --- src/gallium/auxiliary/renderonly/renderonly.c | 3 ++- 1 file changed, 2 inser