Re: [Mesa-dev] [PATCH] radv: perform subpass transitions for resolve attachments

2018-11-16 Thread Samuel Pitoiset
On 11/16/18 3:45 PM, Rhys Perry wrote: Fixes Sascha Willems's multisampling example on my Vega 64. What make you think that this demo is broken? dEQP-VK.renderpass.multisample_resolve.* didn't exhibit issues because of it's images being 32x32 which disabled DCC/CMASK and made these transit

Re: [Mesa-dev] [PATCH] radv: perform subpass transitions for resolve attachments

2018-11-16 Thread Rhys Perry
Actually I just realized that something like https://gitlab.freedesktop.org/mesa/mesa/blob/fe3f13cc5a8/src/amd/vulkan/radv_meta_resolve.c#L678-681 would probably be better. On Fri, 16 Nov 2018 at 14:45, Rhys Perry wrote: > > Fixes Sascha Willems's multisampling example on my Vega 64. > > dEQP-VK.r

[Mesa-dev] [PATCH] radv: perform subpass transitions for resolve attachments

2018-11-16 Thread Rhys Perry
Fixes Sascha Willems's multisampling example on my Vega 64. dEQP-VK.renderpass.multisample_resolve.* didn't exhibit issues because of it's images being 32x32 which disabled DCC/CMASK and made these transitions unnecessary. Signed-of-by: Rhys Perry CC: --- src/amd/vulkan/radv_cmd_buffer.c | 6 +