Re: [Mesa-dev] [PATCH] radv: implement multisample image copies

2018-03-09 Thread Bas Nieuwenhuizen
Hi Dave, I'd appreciate if you could split all the ac stuff into a separate patch. The big issue I see with the patch is that we don't support multisample image stores yet. In particular, you have to copy over the fmask value (and find a way to skip over the fmask lookup in the tex instruction) o

[Mesa-dev] [PATCH] radv: implement multisample image copies

2018-03-08 Thread Dave Airlie
From: Dave Airlie It appears its quite legal to do image copies on multisample images, however due to a bug in our txf handling and incomplete tests we never actually noticed we didn't do it properly in radv. This patch implements a compute shader to copy multiple samples of an image to another