Re: [Mesa-dev] [PATCH] radv: fix dual source blending

2016-12-21 Thread Fredrik Höglund
On Monday 19 December 2016, Bas Nieuwenhuizen wrote: > Reviewed-by: Bas Nieuwenhuizen > > Does dual source blending work now with this patch? And do you need me > to commit it? It does for me. And no, I believe I have commit access. Thanks for the review! > - Bas > > > On Fri, Dec 16, 2016 a

Re: [Mesa-dev] [PATCH] radv: fix dual source blending

2016-12-18 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen Does dual source blending work now with this patch? And do you need me to commit it? - Bas On Fri, Dec 16, 2016 at 2:25 AM, Fredrik Höglund wrote: > Add the index to the location when assigning driver locations for > output variables. > > Otherwise two fragment

[Mesa-dev] [PATCH] radv: fix dual source blending

2016-12-15 Thread Fredrik Höglund
Add the index to the location when assigning driver locations for output variables. Otherwise two fragment shader outputs declared as: layout (location = 0, index = 0) out vec4 output1; layout (location = 0, index = 1) out vec4 output2; will end up aliasing one another. Note that this pat

Re: [Mesa-dev] [PATCH] radv: fix dual source blending

2016-11-01 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 11/02/2016 11:35 AM, Dave Airlie wrote: > From: Dave Airlie > > Dolphin tried to use this, but we hadn't had any tests for it properly. > > All that is required is the shader output format needs to be set > for 0 and 1 exports. > > Cc: "13.0" > Signed-off-by:

[Mesa-dev] [PATCH] radv: fix dual source blending

2016-11-01 Thread Dave Airlie
From: Dave Airlie Dolphin tried to use this, but we hadn't had any tests for it properly. All that is required is the shader output format needs to be set for 0 and 1 exports. Cc: "13.0" Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 12 +--- 1 file changed, 9 insert