Re: [Mesa-dev] [PATCH] radv: fix centroid interpolation

2018-05-21 Thread Bas Nieuwenhuizen
On Mon, May 21, 2018 at 2:37 PM, Ilia Mirkin wrote: > What do centroid / sample interpolation modes mean in a non-msaa > environment? Or does key.fs.multisample mean something else? Yeah that was what I was wondering too. It is valid for shaders to use so we should handel it, but I suspect under

Re: [Mesa-dev] [PATCH] radv: fix centroid interpolation

2018-05-21 Thread Ilia Mirkin
What do centroid / sample interpolation modes mean in a non-msaa environment? Or does key.fs.multisample mean something else? On Mon, May 21, 2018 at 5:15 AM, Samuel Pitoiset wrote: > It's legal to set the centroid and sample interpolation modes > when MSAA disabled. So, we have to initialize the

Re: [Mesa-dev] [PATCH] radv: fix centroid interpolation

2018-05-21 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, May 21, 2018 at 11:15 AM, Samuel Pitoiset wrote: > It's legal to set the centroid and sample interpolation modes > when MSAA disabled. So, we have to initialize the centroid > inputs because the hardware doesn't. > > This fixes rendering issues with DXVK an

[Mesa-dev] [PATCH] radv: fix centroid interpolation

2018-05-21 Thread Samuel Pitoiset
It's legal to set the centroid and sample interpolation modes when MSAA disabled. So, we have to initialize the centroid inputs because the hardware doesn't. This fixes rendering issues with DXVK and The Witness, World of Warcraft, Trackmania and probably more games. Bugzilla: https://bugs.freede