Re: [Mesa-dev] [PATCH] radv: fix binding transform feedback buffers

2019-03-11 Thread Samuel Pitoiset
On 3/11/19 10:05 AM, Bas Nieuwenhuizen wrote: hmm, nothing to disabled them again? Apparently not? Except vkResetCommandBuffer() of course. According to the spec, the behaviour of CmdBindTransformFeedbackBuffersEXT() is similar to the other binding funcs (eg. vertex buffers). Maybe we sho

Re: [Mesa-dev] [PATCH] radv: fix binding transform feedback buffers

2019-03-11 Thread Bas Nieuwenhuizen
hmm, nothing to disabled them again? Reviewed-by: Bas Nieuwenhuizen On Tue, Mar 5, 2019 at 6:06 PM Samuel Pitoiset wrote: > > The mask should be accumulated if two calls are used for > binding two buffers at different indexes. Otherwise, the > driver only accounts for the last one. > > Noticed

[Mesa-dev] [PATCH] radv: fix binding transform feedback buffers

2019-03-05 Thread Samuel Pitoiset
The mask should be accumulated if two calls are used for binding two buffers at different indexes. Otherwise, the driver only accounts for the last one. Noticed while glancing at this code. Cc: 18.3 19.0 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed