Re: [Mesa-dev] [PATCH] radv: fix Coverity no effect control flow issue

2018-06-07 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 06/07/2018 01:49 AM, Timothy Arceri wrote: swizzle is unsigned so "desc->swizzle[c] < 0" is never true. --- src/amd/vulkan/radv_formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_fo

Re: [Mesa-dev] [PATCH] radv: fix Coverity no effect control flow issue

2018-06-06 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jun 7, 2018 at 1:49 AM, Timothy Arceri wrote: > swizzle is unsigned so "desc->swizzle[c] < 0" is never true. > --- > src/amd/vulkan/radv_formats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_formats.c b/src/

[Mesa-dev] [PATCH] radv: fix Coverity no effect control flow issue

2018-06-06 Thread Timothy Arceri
swizzle is unsigned so "desc->swizzle[c] < 0" is never true. --- src/amd/vulkan/radv_formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index 50ec904d514..958f2a2c821 100644 --- a/src/amd/vulkan/radv_formats.c