Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2018-01-05 Thread Samuel Pitoiset
On 01/04/2018 07:54 PM, Bas Nieuwenhuizen wrote: Reviewed-by: Bas Nieuwenhuizen Yeah, I think it's easier to fix it that way for now. Thanks! On Thu, Dec 28, 2017 at 10:55 PM, Samuel Pitoiset wrote: Similar to RadeonSI. This fixes: dEQP-VK.image.texel_view_compatible.graphic.basic.atta

Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2018-01-04 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Dec 28, 2017 at 10:55 PM, Samuel Pitoiset wrote: > Similar to RadeonSI. > > This fixes: > dEQP-VK.image.texel_view_compatible.graphic.basic.attachment_read.bc*r16g16b16a16_sfloat > dEQP-VK.image.extended_usage_bit.attachment_write.r16_sfloat > > Signed-off-

Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2018-01-04 Thread Bas Nieuwenhuizen
Looking at AMDGPUAsmPrinter::EmitProgramInfoSI in LLVM that is only set for compute shaders. So fix radv to default to the proposed value and fix LLVM to pass it through for all shaders? On Thu, Jan 4, 2018 at 11:54 AM, Samuel Pitoiset wrote: > > > On 12/28/2017 11:08 PM, Matt Arsenault wrote: >>

Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2018-01-04 Thread Samuel Pitoiset
On 12/28/2017 11:08 PM, Matt Arsenault wrote: On Dec 28, 2017, at 16:55, Samuel Pitoiset wrote: Similar to RadeonSI. This fixes: dEQP-VK.image.texel_view_compatible.graphic.basic.attachment_read.bc*r16g16b16a16_sfloat dEQP-VK.image.extended_usage_bit.attachment_write.r16_sfloat Signed-of

Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2017-12-28 Thread Samuel Pitoiset
On 12/28/2017 11:08 PM, Matt Arsenault wrote: On Dec 28, 2017, at 16:55, Samuel Pitoiset wrote: Similar to RadeonSI. This fixes: dEQP-VK.image.texel_view_compatible.graphic.basic.attachment_read.bc*r16g16b16a16_sfloat dEQP-VK.image.extended_usage_bit.attachment_write.r16_sfloat Signed-of

Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2017-12-28 Thread Matt Arsenault
> On Dec 28, 2017, at 16:55, Samuel Pitoiset wrote: > > Similar to RadeonSI. > > This fixes: > dEQP-VK.image.texel_view_compatible.graphic.basic.attachment_read.bc*r16g16b16a16_sfloat > dEQP-VK.image.extended_usage_bit.attachment_write.r16_sfloat > > Signed-off-by: Samuel Pitoiset > --- > sr

[Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2017-12-28 Thread Samuel Pitoiset
Similar to RadeonSI. This fixes: dEQP-VK.image.texel_view_compatible.graphic.basic.attachment_read.bc*r16g16b16a16_sfloat dEQP-VK.image.extended_usage_bit.attachment_write.r16_sfloat Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 14 ++ 1 file changed, 14 inser