Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-19 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Sat, Jan 19, 2019 at 2:56 PM Rhys Perry wrote: > > It's common in some applications to bind a new graphics pipeline without > ending up changing any context registers. > > This has a pipline have two command buffers: one for setting context > registers and one f

[Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-19 Thread Rhys Perry
It's common in some applications to bind a new graphics pipeline without ending up changing any context registers. This has a pipline have two command buffers: one for setting context registers and one for everything else. The context register command buffer is only emitted if it differs from the

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-18 Thread Bas Nieuwenhuizen
Besides CTS, I'd appreciate if you can test with Talos, as that was the msot affected by bugs in this code. Otherwise, Reviewed-by: Bas Nieuwenhuizen On Mon, Jan 14, 2019 at 5:02 PM Rhys Perry wrote: > > It's common in some applications to bind a new graphics pipeline without > ending up chang

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-16 Thread Rhys Perry
Seems I accidentally had it use Fedora 29's mesa build in both the before and after runs... Running again I get (again, average of 3 runs): GeothermalValley: 58.2 fps -> 59.633 fps (+2.5%) ProphetsTomb: 59 fps -> 60 fps (+1.7%) SpineOfTheMountain: 64 fps -> 64.06667 fps (+0.1%) (1 extreme f

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-16 Thread Rhys Perry
Rise of the Tomb Raider from without to with the change (average of 3 runs): SpineOfTheMountain: 73.46667 fps -> 73.56667 fps (+0.14%) ProphetsTomb: 58.4 fps -> 58.46667 fps (+0.11%) GeothermalValley: 57.2 fps -> 57.46667 fps (+0.47%) So not much improvement (if any). On Wed, 16 J

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-15 Thread Rhys Perry
I did a before/after comparison during development with multiple runs but only 1 before and after run to produce the numbers I sent. They seemed to match up well enough to the runs during development, so I wasn't too concerned. IIRC, the two runs were with a Vega 64 at 1080p with "High" settings.

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-15 Thread Bas Nieuwenhuizen
On Mon, Jan 14, 2019 at 5:12 PM Rhys Perry wrote: > > I did and found small improvements in Rise of the Tomb Raider. I > measured framerates ~104.3% that of without the changes for the > Geothermal Valley scene, ~101.2% for Spine of the Mountain and ~102.3% > for Prophets Tomb. My main question w

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-14 Thread Rhys Perry
Sure On Mon, 14 Jan 2019 at 16:50, Samuel Pitoiset wrote: > > While you are on it, can you experiment the tracked ctx stuff that > RadeonSI implements (ie. SI_TRACKED_XXX)? > > This approach will likely be more costly from the CPU side, but it will > reduce the number of register changes a lot mo

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-14 Thread Samuel Pitoiset
While you are on it, can you experiment the tracked ctx stuff that RadeonSI implements (ie. SI_TRACKED_XXX)? This approach will likely be more costly from the CPU side, but it will reduce the number of register changes a lot more. Not sure if that will improve anything though, but I think it'

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-14 Thread Rhys Perry
This is with Rise of the Tomb Raider's graphics settings set to "High" by the way. On Mon, 14 Jan 2019 at 16:12, Rhys Perry wrote: > > I did and found small improvements in Rise of the Tomb Raider. I > measured framerates ~104.3% that of without the changes for the > Geothermal Valley scene, ~101

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-14 Thread Rhys Perry
I did and found small improvements in Rise of the Tomb Raider. I measured framerates ~104.3% that of without the changes for the Geothermal Valley scene, ~101.2% for Spine of the Mountain and ~102.3% for Prophets Tomb. I found no change with Dota 2 but I've heard it's cpu-bound. On Mon, 14 Jan 20

Re: [Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-14 Thread Samuel Pitoiset
Did you benchmark? On 1/14/19 5:01 PM, Rhys Perry wrote: It's common in some applications to bind a new graphics pipeline without ending up changing any context registers. This has a pipline have two command buffers: one for setting context registers and one for everything else. The context reg

[Mesa-dev] [PATCH] radv: avoid context rolls when binding graphics pipelines

2019-01-14 Thread Rhys Perry
It's common in some applications to bind a new graphics pipeline without ending up changing any context registers. This has a pipline have two command buffers: one for setting context registers and one for everything else. The context register command buffer is only emitted if it differs from the