Re: [Mesa-dev] [PATCH] radv/xfb: don't increase offset by component mask start.

2018-10-31 Thread Samuel Pitoiset
Seems fine. Reviewed-by: Samuel Pitoiset On 10/31/18 3:58 AM, Dave Airlie wrote: From: Dave Airlie This is incorrect, the offset is into the buffer, and it's legal to write loc 0,0 -> buffer0, offset 0 loc 0,1 -> buffer1, offset 0 This fixes a bunch of piglits running on my zink xfb code o

[Mesa-dev] [PATCH] radv/xfb: don't increase offset by component mask start.

2018-10-30 Thread Dave Airlie
From: Dave Airlie This is incorrect, the offset is into the buffer, and it's legal to write loc 0,0 -> buffer0, offset 0 loc 0,1 -> buffer1, offset 0 This fixes a bunch of piglits running on my zink xfb code on radv. Fixes: 6c21645046 (radv: emit stream outputs for vertex and tessellation stag