Re: [Mesa-dev] [PATCH] radeonsi: remove Constant Engine support

2017-08-22 Thread Nicolai Hähnle
I think it makes sense. There is some natural rebasing required to fix this up with the recent changes to how IBs are saved, but with those done the patch is Reviewed-by: Nicolai Hähnle On 22.08.2017 11:29, Samuel Pitoiset wrote: On 08/21/2017 10:56 PM, Marek Olšák wrote: On Mon, Aug 21,

Re: [Mesa-dev] [PATCH] radeonsi: remove Constant Engine support

2017-08-22 Thread Samuel Pitoiset
On 08/21/2017 10:56 PM, Marek Olšák wrote: On Mon, Aug 21, 2017 at 8:49 PM, Samuel Pitoiset wrote: dirty_mask can be removed entirely because it only makes sense with CE. Thanks. Removed locally. With this removed, patch is: Reviewed-by: Samuel Pitoiset Marek __

Re: [Mesa-dev] [PATCH] radeonsi: remove Constant Engine support

2017-08-21 Thread Marek Olšák
On Mon, Aug 21, 2017 at 8:49 PM, Samuel Pitoiset wrote: > dirty_mask can be removed entirely because it only makes sense with CE. Thanks. Removed locally. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mail

Re: [Mesa-dev] [PATCH] radeonsi: remove Constant Engine support

2017-08-21 Thread Samuel Pitoiset
dirty_mask can be removed entirely because it only makes sense with CE. On 08/19/2017 07:03 PM, Marek Olšák wrote: From: Marek Olšák We have come to the conclusion that it doesn't improve performance. --- src/gallium/drivers/radeon/r600_gpu_load.c| 3 - src/gallium/drivers/radeon/r600

Re: [Mesa-dev] [PATCH] radeonsi: remove Constant Engine support

2017-08-20 Thread Dieter Nützel
Tested-by: Dieter Nützel on RX580 smaller foot print, now;-) Dieter Am 19.08.2017 19:03, schrieb Marek Olšák: From: Marek Olšák We have come to the conclusion that it doesn't improve performance. --- src/gallium/drivers/radeon/r600_gpu_load.c| 3 - src/gallium/drivers/radeon/r600_pi

[Mesa-dev] [PATCH] radeonsi: remove Constant Engine support

2017-08-19 Thread Marek Olšák
From: Marek Olšák We have come to the conclusion that it doesn't improve performance. --- src/gallium/drivers/radeon/r600_gpu_load.c| 3 - src/gallium/drivers/radeon/r600_pipe_common.c | 2 - src/gallium/drivers/radeon/r600_pipe_common.h | 5 +- src/gallium/drivers/radeon/r600_query.c