Re: [Mesa-dev] [PATCH] radeonsi: Track pipe_vertex_buffers for relocs.

2018-05-22 Thread Mathias Fröhlich
Hi Marek, On Tuesday, 22 May 2018 02:09:44 CEST Marek Olšák wrote: > And the old code does exactly the same thing - it avoids duplicate calls > for the same pipe_vertex_buffer, because vertex elements reusing vertex > buffer slots don't have their bit set in first_vb_use_mask, so > add_to_buffer_l

Re: [Mesa-dev] [PATCH] radeonsi: Track pipe_vertex_buffers for relocs.

2018-05-21 Thread Marek Olšák
On Sun, May 20, 2018 at 2:21 PM, Mathias Fröhlich wrote: > Hi Marek, > > On Sunday, 20 May 2018 20:08:08 CEST Marek Olšák wrote: > > The old code saves which vertex element is the first to use a VBO slot. > > When VBOs are added to the buffer list, each VBO is added only for such > > vertex eleme

Re: [Mesa-dev] [PATCH] radeonsi: Track pipe_vertex_buffers for relocs.

2018-05-20 Thread Mathias Fröhlich
Hi Marek, On Sunday, 20 May 2018 20:08:08 CEST Marek Olšák wrote: > The old code saves which vertex element is the first to use a VBO slot. > When VBOs are added to the buffer list, each VBO is added only for such > vertex elements, and not added for others. So the old and new code do > exactly th

Re: [Mesa-dev] [PATCH] radeonsi: Track pipe_vertex_buffers for relocs.

2018-05-20 Thread Marek Olšák
The old code saves which vertex element is the first to use a VBO slot. When VBOs are added to the buffer list, each VBO is added only for such vertex elements, and not added for others. So the old and new code do exactly the same thing but differently. Marek On Sun, May 20, 2018 at 11:40 AM, Mat

Re: [Mesa-dev] [PATCH] radeonsi: Track pipe_vertex_buffers for relocs.

2018-05-20 Thread Mathias Fröhlich
Hi Marek, On Sunday, 20 May 2018 16:42:51 CEST Marek Olšák wrote: > Can you explain what the difference is between the old and new code? The old code used a bit for each vertex attribute that is uploaded, the new code uses a bit for each buffer binding. Vertex attributes refer to a buffer binding

Re: [Mesa-dev] [PATCH] radeonsi: Track pipe_vertex_buffers for relocs.

2018-05-20 Thread Marek Olšák
Can you explain what the difference is between the old and new code? Marek On Sat, May 19, 2018 at 4:30 AM, wrote: > From: Mathias Fröhlich > > Hi, > > Below a patch to radeonsi to get a small bit more out of the recent > VAO changes. > The change did not introduce regressions into piglit and

[Mesa-dev] [PATCH] radeonsi: Track pipe_vertex_buffers for relocs.

2018-05-19 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, Below a patch to radeonsi to get a small bit more out of the recent VAO changes. The change did not introduce regressions into piglit and some variant of deqp availble through piglit on a radeonsi system. Please review! best Mathias Instead of tracking which pipe_ve