Re: [Mesa-dev] [PATCH] radeon/r200: Fix FBO formats

2013-01-17 Thread Milan Kostić
It is weird, i am not sure what happens neither. I assume because in emit_cb_setup XRGB is mapped to dst_format R200_COLOR_FORMAT_ARGB, but in emit_tx_setup XRGB src_mesa_format not have alpha. It looks OK but does not work good for some reason, so i added R200_TXFORMAT_ALPHA_IN_MAP to

Re: [Mesa-dev] [PATCH] radeon/r200: Fix FBO formats

2013-01-17 Thread Roland Scheidegger
Am 16.01.2013 17:52, schrieb Milan Kostić: > No, no regress in piglit i've seen at all, only better... i even > played whole Drawn 2 game: > http://www.drawngame.com/games/dark-flight > under wine in OpenGL mode, it works perfectly now, needs culling under > fbo which is fixed now and this fix to

Re: [Mesa-dev] [PATCH] radeon/r200: Fix FBO formats

2013-01-16 Thread Milan Kostić
No, no regress in piglit i've seen at all, only better... i even played whole Drawn 2 game: http://www.drawngame.com/games/dark-flight under wine in OpenGL mode, it works perfectly now, needs culling under fbo which is fixed now and this fix to display text and so works exactly the same as with n

Re: [Mesa-dev] [PATCH] radeon/r200: Fix FBO formats

2013-01-15 Thread Marek Olšák
On Tue, Jan 15, 2013 at 7:15 PM, Alex Deucher wrote: > On Fri, Jan 11, 2013 at 6:37 AM, smoki wrote: >> Piglit passes more fbo tests on rv280, 14/28 before and now 28/33. >> Also should fix bug: >> https://bugs.freedesktop.org/show_bug.cgi?id=27704 > > Does this regress anything in piglit? It's

Re: [Mesa-dev] [PATCH] radeon/r200: Fix FBO formats

2013-01-15 Thread Alex Deucher
On Fri, Jan 11, 2013 at 6:37 AM, smoki wrote: > Piglit passes more fbo tests on rv280, 14/28 before and now 28/33. > Also should fix bug: > https://bugs.freedesktop.org/show_bug.cgi?id=27704 Does this regress anything in piglit? It's been a while since I looked at this code, I think the issue ma

[Mesa-dev] [PATCH] radeon/r200: Fix FBO formats

2013-01-11 Thread smoki
Piglit passes more fbo tests on rv280, 14/28 before and now 28/33. Also should fix bug: https://bugs.freedesktop.org/show_bug.cgi?id=27704 --- src/mesa/drivers/dri/radeon/radeon_texture.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeo