Re: [Mesa-dev] [PATCH] r600g: fix z/stencil texture creation v2

2012-06-16 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 15, 2012 at 11:40 PM, wrote: > From: Jerome Glisse > > z or stencil texture should not be created with the z/stencil > flags for surface creation as they are intended to be bound > as texture. > > v2: remove broken code > > Signed-off-by: Jerome Glis

[Mesa-dev] [PATCH] r600g: fix z/stencil texture creation v2

2012-06-15 Thread j . glisse
From: Jerome Glisse z or stencil texture should not be created with the z/stencil flags for surface creation as they are intended to be bound as texture. v2: remove broken code Signed-off-by: Jerome Glisse --- src/gallium/drivers/r600/r600_texture.c | 32 -- 1 fi

Re: [Mesa-dev] [PATCH] r600g: fix z/stencil texture creation

2012-06-15 Thread Marek Olšák
On Fri, Jun 15, 2012 at 8:40 PM, Brian Paul wrote: > On Fri, Jun 15, 2012 at 12:29 PM, Marek Olšák wrote: >> Hi Jerome, >> >> Your patch somehow fixes all regressions, but it's not correct. Please >> see below. >> >> On Fri, Jun 15, 2012 at 5:25 PM,   wrote: >>> From: Jerome Glisse >>> >>> z or

Re: [Mesa-dev] [PATCH] r600g: fix z/stencil texture creation

2012-06-15 Thread Brian Paul
On Fri, Jun 15, 2012 at 12:29 PM, Marek Olšák wrote: > Hi Jerome, > > Your patch somehow fixes all regressions, but it's not correct. Please > see below. > > On Fri, Jun 15, 2012 at 5:25 PM,   wrote: >> From: Jerome Glisse >> >> z or stencil texture should not be created with the z/stencil >> fla

Re: [Mesa-dev] [PATCH] r600g: fix z/stencil texture creation

2012-06-15 Thread Marek Olšák
Hi Jerome, Your patch somehow fixes all regressions, but it's not correct. Please see below. On Fri, Jun 15, 2012 at 5:25 PM, wrote: > From: Jerome Glisse > > z or stencil texture should not be created with the z/stencil > flags for surface creation as they are intended to be bound > as textur

[Mesa-dev] [PATCH] r600g: fix z/stencil texture creation

2012-06-15 Thread j . glisse
From: Jerome Glisse z or stencil texture should not be created with the z/stencil flags for surface creation as they are intended to be bound as texture. Signed-off-by: Jerome Glisse --- src/gallium/drivers/r600/r600_texture.c | 34 +- 1 files changed, 19 insertio