Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-04-01 Thread Vadim Girlin
update_max_depth function). Vadim - Mail original - De�: Vadim Girlin �: Vincent Lejeune Cc�: Alex Deucher ; "mesa-dev@lists.freedesktop.org" Envoy� le : Dimanche 31 mars 2013 22h34 Objet�: Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-04-01 Thread Vincent Lejeune
- Mail original - > De : Vadim Girlin > À : Vincent Lejeune > Cc : Alex Deucher ; "mesa-dev@lists.freedesktop.org" > > Envoyé le : Dimanche 31 mars 2013 22h34 > Objet : Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than > required v4 >

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-03-31 Thread Vadim Girlin
On 04/01/2013 12:00 AM, Vincent Lejeune wrote: Hi Vadim, Does this patch work ? (It's still not pushed) It works for me on evergreen, but I'm not sure about other chip generations. I wanted to ask somebody to test it, but the problem is that the piglit coverage for this is not enough (e.g. i

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-03-31 Thread Vincent Lejeune
esktop.org > Envoyé le : Vendredi 22 février 2013 1h37 > Objet : Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than > required v4 > > On 02/22/2013 04:23 AM, Alex Deucher wrote: >> On Thu, Feb 21, 2013 at 6:52 PM, Vadim Girlin > wrote: >>

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-02-21 Thread Vadim Girlin
On 02/22/2013 04:23 AM, Alex Deucher wrote: On Thu, Feb 21, 2013 at 6:52 PM, Vadim Girlin wrote: v4: implement exact computation taking into account wavefront size Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_asm.c| 44 +-- src/gallium/drivers/r600/r600_asm.h

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-02-21 Thread Alex Deucher
On Thu, Feb 21, 2013 at 6:52 PM, Vadim Girlin wrote: > v4: implement exact computation taking into account wavefront size > > Signed-off-by: Vadim Girlin > --- > src/gallium/drivers/r600/r600_asm.c| 44 +-- > src/gallium/drivers/r600/r600_asm.h| 24 -- > src/gallium/drivers

[Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-02-21 Thread Vadim Girlin
v4: implement exact computation taking into account wavefront size Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_asm.c| 44 +-- src/gallium/drivers/r600/r600_asm.h| 24 -- src/gallium/drivers/r600/r600_shader.c | 131 ++--- 3 file

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v3

2013-02-19 Thread Andy Furniss
Vadim Girlin wrote: v3: handle hw-specific cases Signed-off-by: Vadim Girlin --- cc: Andy Furniss Hopefully this should work better on the non-evergreen chips This one seems to work OK for me. ___ mesa-dev mailing list mesa-dev@lists.freedesktop

[Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v3

2013-02-18 Thread Vadim Girlin
v3: handle hw-specific cases Signed-off-by: Vadim Girlin --- cc: Andy Furniss Hopefully this should work better on the non-evergreen chips src/gallium/drivers/r600/r600_asm.c| 4 +- src/gallium/drivers/r600/r600_asm.h| 29 +-- src/gallium/drivers/r600/r600_shader.c | 134 ++

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v2

2013-02-18 Thread Andy Furniss
Vadim Girlin wrote: Overcautious stack reservation caused significant loss of performance. v2: fix stack depth computation I get some corruption with this patch and heaven 3.0 with llvm on HD4890, R600_LLVM=0 is OK. It appears on sunlit areas over a certain distance and the patches move ar

[Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v2

2013-02-17 Thread Vadim Girlin
Overcautious stack reservation caused significant loss of performance. v2: fix stack depth computation Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_asm.c| 4 +-- src/gallium/drivers/r600/r600_asm.h| 10 ++ src/gallium/drivers/r600/r600_shader.c | 64 ---

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required

2013-02-17 Thread Vadim Girlin
Please ignore this, there are some issues with this patch undetected by piglit. I suspect it's something similar to the hw bug discussed here recently: http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg33361.html On 02/18/2013 07:29 AM, Vadim Girlin wrote: Overcautious stack rese

[Mesa-dev] [PATCH] r600g: don't reserve more stack space than required

2013-02-17 Thread Vadim Girlin
Overcautious stack reservation caused significant loss of performance. Signed-off-by: Vadim Girlin --- No regressions with quick-driver.tests on evergreen. Adds more than 30% FPS for Unigine Heaven with default backend. src/gallium/drivers/r600/r600_asm.c | 2 +- 1 file changed, 1 insertion(+)