Re: [Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-15 Thread Andy Furniss
Marek Olšák wrote: On Sun, Jul 15, 2012 at 12:57 PM, Andy Furniss wrote: Marek Olšák wrote: FYI, I have pushed your DB decompression fix, because my not-yet-published work depends on it. I can't be sure whether todays changes caused this, because I can't reproduce it :-( But I haven't see

Re: [Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-15 Thread Marek Olšák
On Sun, Jul 15, 2012 at 12:57 PM, Andy Furniss wrote: > Marek Olšák wrote: >> >> FYI, I have pushed your DB decompression fix, because my >> not-yet-published work depends on it. > > > I can't be sure whether todays changes caused this, because I can't > reproduce it :-( > > But I haven't seen it

Re: [Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-15 Thread Andy Furniss
Andy Furniss wrote: Marek Olšák wrote: FYI, I have pushed your DB decompression fix, because my not-yet-published work depends on it. I can't be sure whether todays changes caused this, because I can't reproduce it :-( Ok so I can reproduce if I am patient enough. Don't know when I'll get t

Re: [Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-15 Thread Andy Furniss
Marek Olšák wrote: FYI, I have pushed your DB decompression fix, because my not-yet-published work depends on it. I can't be sure whether todays changes caused this, because I can't reproduce it :-( But I haven't seen it before and didn't see it 24hrs ago when I ran the same test. Today I

Re: [Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-14 Thread Marek Olšák
FYI, I have pushed your DB decompression fix, because my not-yet-published work depends on it. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-14 Thread Dave Airlie
On Sat, Jul 14, 2012 at 10:20 PM, Marek Olšák wrote: > On Sat, Jul 14, 2012 at 2:20 AM, Jerome Glisse wrote: >> On Fri, Jul 13, 2012 at 8:02 PM, Marek Olšák wrote: >>> Hi Jerome, >>> >>> I have a lot of remarks. >>> >>> 1) The DB decompression fix (where you update DB_RENDER_CONTROL) could >>> b

Re: [Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-14 Thread Marek Olšák
On Sat, Jul 14, 2012 at 2:20 AM, Jerome Glisse wrote: > On Fri, Jul 13, 2012 at 8:02 PM, Marek Olšák wrote: >> Hi Jerome, >> >> I have a lot of remarks. >> >> 1) The DB decompression fix (where you update DB_RENDER_CONTROL) could >> be in a separate patch. >> >> 2) The fix with EARLY_Z_THEN_LATE_

Re: [Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-13 Thread Marek Olšák
On Sat, Jul 14, 2012 at 2:20 AM, Jerome Glisse wrote: > On Fri, Jul 13, 2012 at 8:02 PM, Marek Olšák wrote: >> I don't like this 0xf magic value. Please use proper definitions from >> r600d.h. >> > > Using define will make it a very big line. Yes, a very big line is okay. It took me a while to

Re: [Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-13 Thread Marek Olšák
Hi Jerome, I have a lot of remarks. 1) The DB decompression fix (where you update DB_RENDER_CONTROL) could be in a separate patch. 2) The fix with EARLY_Z_THEN_LATE_Z (in update_dual_export) could also be in a separate patch. 3) r600_context::use_hyperz is set to FALSE by default, why? If the f

[Mesa-dev] [PATCH] r600g: add htile support v8

2012-07-13 Thread j . glisse
From: Jerome Glisse htile is used for HiZ and HiS support and fast Z/S clears. This commit just adds the htile setup and Fast Z clear. We don't take full advantage of HiS with that patch. v2 really use fast clear, still random issue with some tiles need to try more flush combination, fix dept