Re: [Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.

2011-10-29 Thread Mathias Fröhlich
Hi, On Thursday, October 27, 2011 18:17:41 Marek Olšák wrote: > Looks good to me. Ideally even texture_barrier should not be needed. > set_framebuffer_state() and flush() should flush caches automatically. > If they don't, there is a bug. I have pushed this now as an improovement above the forme

Re: [Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.

2011-10-27 Thread Fredrik Höglund
On Thursday 27 October 2011, Mathias Fröhlich wrote: > > Hi, > > On Saturday, October 22, 2011 13:36:37 Mathias Fröhlich wrote: > > The attached patch reduces the amount of pipe flushes for r600g. > > I am not exactly sure if we could skip this flush entirely because of the > > internal r600g win

Re: [Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.

2011-10-27 Thread Marek Olšák
Looks good to me. Ideally even texture_barrier should not be needed. set_framebuffer_state() and flush() should flush caches automatically. If they don't, there is a bug. Marek 2011/10/27 Mathias Fröhlich : > > Hi, > > On Saturday, October 22, 2011 13:36:37 Mathias Fröhlich wrote: >> The attached

Re: [Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.

2011-10-27 Thread Mathias Fröhlich
Hi, On Saturday, October 22, 2011 13:36:37 Mathias Fröhlich wrote: > The attached patch reduces the amount of pipe flushes for r600g. > I am not exactly sure if we could skip this flush entirely because of the > internal r600g winsys flush logic. > But what we can do is the attached patch: > > R

[Mesa-dev] [PATCH] r600g: Replace needless flush in texture upload.

2011-10-22 Thread Mathias Fröhlich
Hi, The attached patch reduces the amount of pipe flushes for r600g. I am not exactly sure if we could skip this flush entirely because of the internal r600g winsys flush logic. But what we can do is the attached patch: Replace pipe->flush() with pipe->texture_barrier() in the texture upload pa