Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_draw_indirect

2014-11-09 Thread Benjamin Bellec
Hello, You have defined some "define" but you don't use it everywhere, for instance : cs->buf[cs->cdw++] = PKT3(0x24 /* PKT3_DRAW_INDIRECT */, 1, rctx->b.predicate_drawing); instead of simply : cs->buf[cs->cdw++] = PKT3(PKT3_DRAW_INDIRECT, 1, rctx->b.predicate_drawing); There is 5 instances lik

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_draw_indirect

2014-11-09 Thread Marek Olšák
This might not always work due to these reasons: These variables shouldn't be used anywhere if info.indirect != NULL: - info.start - info.count - info.index_bias For example, the translation of 8-bit indices is broken. The code which uses these variables has no effect if info.indirect != NULL. Fo

[Mesa-dev] [PATCH] r600g: Implement GL_ARB_draw_indirect

2014-11-08 Thread Glenn Kennard
Requires evergreen/cayman, and updated radeon kernel module. Signed-off-by: Glenn Kennard --- See also kernel side patch sent to dri-de...@lists.freedesktop.org docs/GL3.txt | 4 +- docs/relnotes/10.4.html | 1 + src/gallium/drivers/r600/ev