Re: [Mesa-dev] [PATCH] r600g: Implement ARB_texture_view

2015-10-17 Thread Marek Olšák
Reviewed-by: Marek Olšák If you're interested, feel free to check out my radeonsi patch on mesa-dev. It's simpler. Marek On Fri, Oct 16, 2015 at 1:53 AM, Glenn Kennard wrote: > Signed-off-by: Glenn Kennard > --- > See also additional texture view piglit test case posted to piglit ml, > which

Re: [Mesa-dev] [PATCH] r600g: Implement ARB_texture_view

2015-10-15 Thread Roland Scheidegger
Interesting it doesn't work with llvmpipe, I thought there were tests for this using some other state tracker... My guess is that (for llvmpipe) in prepare_shader_sampling() and lp_setup_set_fragment_sampler_views() we miss adjusting the mip offsets since we only do that if it's an array target, bu

Re: [Mesa-dev] [PATCH] r600g: Implement ARB_texture_view

2015-10-15 Thread Ilia Mirkin
On Thu, Oct 15, 2015 at 7:53 PM, Glenn Kennard wrote: > Signed-off-by: Glenn Kennard > --- > See also additional texture view piglit test case posted to piglit ml, > which tests cases with layer>0. Notably softpipe and llvmpipe fail that > case but i965/hsw, nv50/nvc0 and r600g pass. > > docs/GL

[Mesa-dev] [PATCH] r600g: Implement ARB_texture_view

2015-10-15 Thread Glenn Kennard
Signed-off-by: Glenn Kennard --- See also additional texture view piglit test case posted to piglit ml, which tests cases with layer>0. Notably softpipe and llvmpipe fail that case but i965/hsw, nv50/nvc0 and r600g pass. docs/GL3.txt | 2 +- docs/relnotes/11.1.0.ht