Re: [Mesa-dev] [PATCH] r600g: Correctly initialize the shader key, v2

2013-05-21 Thread Lauri Kasanen
Hi, seems this was missed for 9.1.3. Could someone cherrypick it to the 9.1 branch? - Lauri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] r600g: Correctly initialize the shader key, v2

2013-05-03 Thread Andreas Boll
Pushed as http://cgit.freedesktop.org/mesa/mesa/commit/?id=e495d88453076a4fe552502d66d6a3869ab70e4a 2013/5/3 Marek Olšák > As long as the commit message contains a note matching this regular > expression '^[[:space:]]*NOTE: .*[Cc]andidate', it won't be missed. > Usually the release manager take

Re: [Mesa-dev] [PATCH] r600g: Correctly initialize the shader key, v2

2013-05-03 Thread Marek Olšák
As long as the commit message contains a note matching this regular expression '^[[:space:]]*NOTE: .*[Cc]andidate', it won't be missed. Usually the release manager takes care of cherry-picking if there are no conflicts. Marek On Fri, May 3, 2013 at 5:39 PM, Lauri Kasanen wrote: > On Fri, 3 May 2

Re: [Mesa-dev] [PATCH] r600g: Correctly initialize the shader key, v2

2013-05-03 Thread Lauri Kasanen
On Fri, 3 May 2013 10:54:09 -0400 Alex Deucher wrote: > On Fri, May 3, 2013 at 9:55 AM, Lauri Kasanen wrote: > > This patch fixes constant shader recompiles by initializing the struct > > to zero. For completeness, memcpy is used to copy the key to the shader > > struct. > > > > Candidate for t

Re: [Mesa-dev] [PATCH] r600g: Correctly initialize the shader key, v2

2013-05-03 Thread Alex Deucher
On Fri, May 3, 2013 at 9:55 AM, Lauri Kasanen wrote: > Assigning a struct only copies the members - any padding is left as is. > > Thus this code: > > struct foo_t foo; > foo = bar; > > leaves the padding of foo intact, ie uninitialized random garbage. > > This patch fixes constant shader recompil

Re: [Mesa-dev] [PATCH] r600g: Correctly initialize the shader key, v2

2013-05-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, May 3, 2013 at 3:55 PM, Lauri Kasanen wrote: > Assigning a struct only copies the members - any padding is left as is. > > Thus this code: > > struct foo_t foo; > foo = bar; > > leaves the padding of foo intact, ie uninitialized random garbage. > > This pa

[Mesa-dev] [PATCH] r600g: Correctly initialize the shader key, v2

2013-05-03 Thread Lauri Kasanen
Assigning a struct only copies the members - any padding is left as is. Thus this code: struct foo_t foo; foo = bar; leaves the padding of foo intact, ie uninitialized random garbage. This patch fixes constant shader recompiles by initializing the struct to zero. For completeness, memcpy is use

Re: [Mesa-dev] [PATCH] r600g: Correctly initialize the shader key

2013-05-03 Thread Vadim Girlin
On 05/03/2013 03:10 PM, Lauri Kasanen wrote: Assigning a struct only copies the members - any padding is left as is. Thus this code: struct foo; foo = bar; leaves the padding of foo intact, ie uninitialized random garbage. This patch fixes constant shader recompiles by initializing the struct

[Mesa-dev] [PATCH] r600g: Correctly initialize the shader key

2013-05-03 Thread Lauri Kasanen
Assigning a struct only copies the members - any padding is left as is. Thus this code: struct foo; foo = bar; leaves the padding of foo intact, ie uninitialized random garbage. This patch fixes constant shader recompiles by initializing the struct to zero. Signed-off-by: Lauri Kasanen --- s