Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-06 Thread Oded Gabbay
On Fri, Mar 4, 2016 at 10:08 PM, Marek Olšák wrote: > On Fri, Mar 4, 2016 at 6:53 PM, Oded Gabbay wrote: >> On Fri, Mar 4, 2016 at 6:59 PM, Marek Olšák wrote: >>> On Fri, Mar 4, 2016 at 4:56 PM, Oded Gabbay wrote: On Fri, Mar 4, 2016 at 2:19 PM, Marek Olšák wrote: > Note that the DB o

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-04 Thread Marek Olšák
On Fri, Mar 4, 2016 at 6:53 PM, Oded Gabbay wrote: > On Fri, Mar 4, 2016 at 6:59 PM, Marek Olšák wrote: >> On Fri, Mar 4, 2016 at 4:56 PM, Oded Gabbay wrote: >>> On Fri, Mar 4, 2016 at 2:19 PM, Marek Olšák wrote: Note that the DB only supports tiling and separate depth and stencil, so

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-04 Thread Oded Gabbay
On Mar 4, 2016 7:53 PM, "Oded Gabbay" wrote: > > On Fri, Mar 4, 2016 at 6:59 PM, Marek Olšák wrote: > > On Fri, Mar 4, 2016 at 4:56 PM, Oded Gabbay wrote: > >> On Fri, Mar 4, 2016 at 2:19 PM, Marek Olšák wrote: > >>> Note that the DB only supports tiling and separate depth and stencil, so > >>>

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-04 Thread Oded Gabbay
On Fri, Mar 4, 2016 at 6:59 PM, Marek Olšák wrote: > On Fri, Mar 4, 2016 at 4:56 PM, Oded Gabbay wrote: >> On Fri, Mar 4, 2016 at 2:19 PM, Marek Olšák wrote: >>> Note that the DB only supports tiling and separate depth and stencil, so >>> it's unmappable. Before transfers and sometimes even text

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-04 Thread Marek Olšák
On Fri, Mar 4, 2016 at 4:56 PM, Oded Gabbay wrote: > On Fri, Mar 4, 2016 at 2:19 PM, Marek Olšák wrote: >> Note that the DB only supports tiling and separate depth and stencil, so >> it's unmappable. Before transfers and sometimes even texturing, the buffer >> must be copied via the DB->CB path,

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-04 Thread Oded Gabbay
On Fri, Mar 4, 2016 at 2:19 PM, Marek Olšák wrote: > Note that the DB only supports tiling and separate depth and stencil, so > it's unmappable. Before transfers and sometimes even texturing, the buffer > must be copied via the DB->CB path, because CB supports both interleaved and > linear layouts

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-04 Thread Marek Olšák
Note that the DB only supports tiling and separate depth and stencil, so it's unmappable. Before transfers and sometimes even texturing, the buffer must be copied via the DB->CB path, because CB supports both interleaved and linear layouts. The result is the flushed texture. The goal here is to ens

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-04 Thread Oded Gabbay
On Fri, Mar 4, 2016 at 12:16 PM, Marek Olšák wrote: > I think this is not the right place to do this. It looks like > r600_translate_colorformat and/or r600_colorformat_endian_swap and > r600_translate_texformat should be adjusted instead. > > Marek Adjusted how ? You want me to check specificall

Re: [Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-04 Thread Marek Olšák
I think this is not the right place to do this. It looks like r600_translate_colorformat and/or r600_colorformat_endian_swap and r600_translate_texformat should be adjusted instead. Marek On Thu, Mar 3, 2016 at 4:47 PM, Oded Gabbay wrote: > The following is what happens when trying to do glReadP

[Mesa-dev] [PATCH] r600g: Adjust pipe format when decompressing depth in BE

2016-03-03 Thread Oded Gabbay
The following is what happens when trying to do glReadPixels() with GL_DEPTH_COMPONENT: 1. When decompressing depth in BE, the GPU performs a swap of the depth value when it is written to the memory-mapped buffer. 2. When the pipe format is PIPE_FORMAT_Z24_UNORM_S8_UINT, the values are unpa