On 20 July 2010 01:02, Dave Airlie wrote:
> Its abuse because if you read that your brain would have to go wtf at
> least twice,
>
> I don't mind !!, since your brain can deal with that, but using binary
> operators where you really want logical is really bad for the reader.
>
> Open source code s
This supersedes
http://lists.freedesktop.org/archives/mesa-dev/2010-July/001442.html.
---
src/mesa/drivers/dri/r600/r700_fragprog.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/r600/r700_fragprog.c
b/src/mesa/drivers/dri/r600/r700_fragprog.c
in
On Tue, Jul 20, 2010 at 7:27 AM, Henri Verbeet wrote:
> On 19 July 2010 23:13, Matt Turner wrote:
>> I can't speak to the meaning of this change, but the use of ^ and !!
>> is just an abuse of the language.
>>
>> ^ is binary XOR. Logical XOR is !=.
>>
>> Let's write this like
>> if ((ctx->Poin
On 19 July 2010 23:13, Matt Turner wrote:
> I can't speak to the meaning of this change, but the use of ^ and !!
> is just an abuse of the language.
>
> ^ is binary XOR. Logical XOR is !=.
>
> Let's write this like
> if ((ctx->Point.SpriteOrigin == GL_LOWER_LEFT) !=
> (ctx->DrawBuffer->Name !=
On Mon, Jul 19, 2010 at 4:50 PM, Henri Verbeet wrote:
> ---
> src/mesa/drivers/dri/r600/r700_fragprog.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/r600/r700_fragprog.c
> b/src/mesa/drivers/dri/r600/r700_fragprog.c
> index bf17a97..fa0189
---
src/mesa/drivers/dri/r600/r700_fragprog.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/r600/r700_fragprog.c
b/src/mesa/drivers/dri/r600/r700_fragprog.c
index bf17a97..fa01890 100644
--- a/src/mesa/drivers/dri/r600/r700_fragprog.c
+++ b/src/m
