Re: [Mesa-dev] [PATCH] r300g: Use automake to generate Makefile v2

2012-02-22 Thread Matt Turner
First off, it doesn't build for me -- mklib: Making Linux shared library: r300_dri.so.tmp /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.2/../../../../x86_64-pc-linux-gnu/bin/ld: ../../../../src/gallium/drivers/r300/libr300.a(r300_screen.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used w

[Mesa-dev] [PATCH] r300g: Use automake to generate Makefile v2

2012-02-22 Thread Tom Stellard
v2: - s/$(top_builddir)/$(top_srcdir)/ - Always generate Makefile.in --- configure.ac |1 + src/gallium/drivers/r300/.gitignore|5 ++ src/gallium/drivers/r300/Makefile | 25 - src/gallium/drivers/r300/Make

Re: [Mesa-dev] [PATCH] r300g: Use automake to generate Makefile

2012-02-20 Thread Dan Nicholson
On Feb 19, 2012 7:39 PM, "Tom Stellard" wrote: > > On Sun, Feb 19, 2012 at 10:13:48PM -0500, Matt Turner wrote: > > Hi Tom, > > > > Very happy to see this. It looks good, and I'm glad that you replaced > > two Makefiles with only a single Makefile.am. A couple of comments > > below. > > > > On Sun

Re: [Mesa-dev] [PATCH] r300g: Use automake to generate Makefile

2012-02-19 Thread Tom Stellard
On Sun, Feb 19, 2012 at 10:13:48PM -0500, Matt Turner wrote: > Hi Tom, > > Very happy to see this. It looks good, and I'm glad that you replaced > two Makefiles with only a single Makefile.am. A couple of comments > below. > > On Sun, Feb 19, 2012 at 10:05 PM, Tom Stellard wrote: > > --- > >  co

Re: [Mesa-dev] [PATCH] r300g: Use automake to generate Makefile

2012-02-19 Thread Matt Turner
Hi Tom, Very happy to see this. It looks good, and I'm glad that you replaced two Makefiles with only a single Makefile.am. A couple of comments below. On Sun, Feb 19, 2012 at 10:05 PM, Tom Stellard wrote: > --- >  configure.ac                                       |    1 + >  src/gallium/driver

[Mesa-dev] [PATCH] r300g: Use automake to generate Makefile

2012-02-19 Thread Tom Stellard
--- configure.ac |1 + src/gallium/drivers/r300/.gitignore|5 ++ src/gallium/drivers/r300/Makefile | 25 - src/gallium/drivers/r300/Makefile.am | 38 ++ src/gallium/drivers/r300/com