Re: [Mesa-dev] [PATCH] program: use extern "C" where appropriate in sampler.cpp

2014-12-16 Thread Mark Janes
Brian Paul writes: > I don't think this is right. The functions in question are C++ > functions and they're only called from .cpp files. I don't see why > C-style linkage is desired. > > See https://bugs.freedesktop.org/show_bug.cgi?id=87371 for another > approach. Please test that patch if

Re: [Mesa-dev] [PATCH] program: use extern "C" where appropriate in sampler.cpp

2014-12-16 Thread Brian Paul
On 12/16/2014 02:08 PM, Mark Janes wrote: `make check` fails to link test_vec4_copy_propagation after 6dac455e. --- src/mesa/program/sampler.cpp | 5 ++--- src/mesa/program/sampler.h | 7 +++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/sampler.cpp b/s

[Mesa-dev] [PATCH] program: use extern "C" where appropriate in sampler.cpp

2014-12-16 Thread Mark Janes
`make check` fails to link test_vec4_copy_propagation after 6dac455e. --- src/mesa/program/sampler.cpp | 5 ++--- src/mesa/program/sampler.h | 7 +++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/sampler.cpp b/src/mesa/program/sampler.cpp index f8584c9..7754