Re: [Mesa-dev] [PATCH] panfrost: Fix two uninitialized accesses in compiler

2019-05-08 Thread Alyssa Rosenzweig
Oh, I have a hunch what could be happening. I'll take a look before merging :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] panfrost: Fix two uninitialized accesses in compiler

2019-05-07 Thread Tomeu Vizoso
On Tue, 7 May 2019 at 23:47, Alyssa Rosenzweig wrote: > > Tentative R-b, but I'm baffled what the flip-flops would be about. Could > you link the list of failures introduced (we're maybe relying on buggy > behaviour anyway)? I was testing with dEQP-GLES2.functional.fragment_ops.blend.equation_src

Re: [Mesa-dev] [PATCH] panfrost: Fix two uninitialized accesses in compiler

2019-05-07 Thread Alyssa Rosenzweig
Tentative R-b, but I'm baffled what the flip-flops would be about. Could you link the list of failures introduced (we're maybe relying on buggy behaviour anyway)? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailm

[Mesa-dev] [PATCH] panfrost: Fix two uninitialized accesses in compiler

2019-05-07 Thread Tomeu Vizoso
Valgrind was complaining of those. NIR_PASS only sets progress to TRUE if there was progress. nir_const_load_to_arr() only sets as many constants as components has the instruction. This was causing some dEQP tests to flip-flop. Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/midg