Re: [Mesa-dev] [PATCH] os: Allow file streams to be open in binary mode.

2010-11-04 Thread José Fonseca
On Thu, 2010-11-04 at 09:58 -0700, Michal Krol wrote: > W dniu 2010-11-04 17:56, José Fonseca pisze: > > Michal, > > > > I think we can just use binary all the time. > > > > Really? There are some consumers of this function that produce text > files, like XML output of trace. Though I think we sh

Re: [Mesa-dev] [PATCH] os: Allow file streams to be open in binary mode.

2010-11-04 Thread Michal Krol
W dniu 2010-11-04 17:56, José Fonseca pisze: Michal, I think we can just use binary all the time. Really? There are some consumers of this function that produce text files, like XML output of trace. Though I think we should be fine with those having linux newlines... On Thu, 2010-11-04

Re: [Mesa-dev] [PATCH] os: Allow file streams to be open in binary mode.

2010-11-04 Thread José Fonseca
Michal, I think we can just use binary all the time. Jose On Thu, 2010-11-04 at 09:29 -0700, Michal Krol wrote: > From efd52ac32547c80d1d8317fe2934a6742968a394 Mon Sep 17 00:00:00 2001 > From: Michal Krol > Date: Thu, 4 Nov 2010 17:29:01 +0100 > Subject: [PATCH] os: Allow file streams to be ope

[Mesa-dev] [PATCH] os: Allow file streams to be open in binary mode.

2010-11-04 Thread Michal Krol
>From efd52ac32547c80d1d8317fe2934a6742968a394 Mon Sep 17 00:00:00 2001 From: Michal Krol Date: Thu, 4 Nov 2010 17:29:01 +0100 Subject: [PATCH] os: Allow file streams to be open in binary mode. Explicitly request binary file mode by adding OS_STREAM_CREATE_BINARY flag to os_file_stream_create().