Re: [Mesa-dev] [PATCH] nvc0: avoid using magic numbers for the uniform_bo offsets

2016-02-27 Thread Samuel Pitoiset
On 02/25/2016 12:16 AM, Ilia Mirkin wrote: On Wed, Feb 24, 2016 at 3:35 PM, Samuel Pitoiset wrote: +/* TIC/TSC entries (6 user clip planes, base instance id) */ +#define NVC0_CB_AUX_TXC_INFO0x000 +#define NVC0_CB_AUX_TXC_SIZE(8 * 4) This makes no sense. UCP's and base instan

Re: [Mesa-dev] [PATCH] nvc0: avoid using magic numbers for the uniform_bo offsets

2016-02-24 Thread Ilia Mirkin
On Wed, Feb 24, 2016 at 3:35 PM, Samuel Pitoiset wrote: > +/* TIC/TSC entries (6 user clip planes, base instance id) */ > +#define NVC0_CB_AUX_TXC_INFO0x000 > +#define NVC0_CB_AUX_TXC_SIZE(8 * 4) This makes no sense. UCP's and base instances have nothing to do with texture stuff.

[Mesa-dev] [PATCH] nvc0: avoid using magic numbers for the uniform_bo offsets

2016-02-24 Thread Samuel Pitoiset
Instead make use of constants to improve readability. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c| 13 +- src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 25 +++ src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 12 +-