Re: [Mesa-dev] [PATCH] nv50,nvc0: fix Z24 formats

2014-09-11 Thread David Heidelberger
I started using PIPE_FORMAT_X8Z24_UNORM and PIPE_FORMAT_S8_UINT_Z24_UNORM in Nine state tracker. As it shows up, it caused problems on NVC0 (PGRAPH errors), which are solved by adding PIPE_FORMAT_X8Z24_UNORM in nvc0_miptree.c. By quick grep I also noticed, there is lot places in nv50, where m

Re: [Mesa-dev] [PATCH] nv50,nvc0: fix Z24 formats

2014-09-11 Thread Ilia Mirkin
On Thu, Sep 11, 2014 at 5:45 PM, David Heidelberger wrote: > also fixes nv50_blit_eng2d_get_mask for PIPE_FORMAT_X8Z24_UNORM Can you explain the problem a little bit and what the end-effect of this fix is? If not, that's OK, I can probably work it out... > > Tested-by: Tiziano Bacocco (on NVC0)

[Mesa-dev] [PATCH] nv50,nvc0: fix Z24 formats

2014-09-11 Thread David Heidelberger
also fixes nv50_blit_eng2d_get_mask for PIPE_FORMAT_X8Z24_UNORM Tested-by: Tiziano Bacocco (on NVC0) Signed-off-by: David Heidelberger --- src/gallium/drivers/nouveau/nv50/nv50_blit.h| 26 - src/gallium/drivers/nouveau/nv50/nv50_surface.c | 1 + src/gallium/drive